Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups

[Andreas Jaeger <aj at suse dot de>]

Julian Brown <julian@codesourcery.com> writes:

> Mark Mitchell wrote:
>> Julian Brown wrote:
>>
>>> Hi,
>>>
>>> This patch stops entities with vague linkage from being declared as
>>> ELF weak symbols when HAVE_GAS_COMDAT_GROUP is true. This is mainly
>>> cosmetic, but could lead to subtle interoperability problems.
>>>
>>> Tested with cross to arm-none-eabi.
>>>
>>> OK to apply?
>> Is there any reason not to do this in elf.h?  It doesn't seem
>> ARM-specific to me.  Would you try making that change, and testing
>> on IA32 GNU/Linux as well?  Does anyone see backwards compatibility
>> problems here?
>
> It doesn't lead to any new regressions on HEAD for i686-pc-linux-gnu 
> with the alteration in config/elfos.h instead.

I propose to revert this patch since it cannot have been tested on
i686-linux-gnu with all languages, it breaks e.g. Java bootstrap.

> So now I guess this could be applied to both HEAD & csl-arm-branch. OK?
>
> ChangeLog:
>
> 	* config/elfos.h (MAKE_DECL_ONE_ONLY): Redefined to stop
> 	DECL_WEAK from being used for symbols with vague linkage when
> 	HAVE_GAS_COMDAT_GROUP is true.

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature