This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR debug/20161


On Fri, 25 Feb 2005, Daniel Berlin wrote:
> On Fri, 2005-02-25 at 07:25 +0100, Steven Bosscher wrote:
> > we ICE when generating debug info, because drarf2out.c does not
> > expect to find error_mark_nodes in the formal argument list. So
> > I just make gen_formal_types_die a little more roboust.
> >
> > The patch below was bootstrapped and tested on x86_64-suse.
> > OK for mainline?
>
> Wouldn't it be much easier and more robust to not call any of the
> debug_hooks from toplev/final if error_count > 0, then it is to try to
> add checks for error_mark_node all over the debug writers?

IIRC, we used to return early from final stages if error_count > 0.

Since error_count > 0 and we used to ICE, I'm *pretty* sure that
can't have detrimental effects down the road. :-)

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]