This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [libstdc++ PATCH] Fix leak in _Rb_tree::_M_insert (stl_tree.h)

From: Jonathan Wakely <cow at compsoc dot man dot ac dot uk>
To: Earl Chew <earl_chew at agilent dot com>
Cc: Gabriel Dos Reis <gdr at integrable-solutions dot net>, libstdc++ at gcc dot gnu dot org,gcc-patches at gcc dot gnu dot org
Date: Fri, 25 Feb 2005 12:58:13 +0000
Subject: Re: [libstdc++ PATCH] Fix leak in _Rb_tree::_M_insert (stl_tree.h)
References: <421E8AE2.1050108@agilent.com> <m3sm3le3qw.fsf@uniton.integrable-solutions.net> <421EB7B7.4060106@agilent.com>

On Thu, Feb 24, 2005 at 09:29:27PM -0800, Earl Chew wrote:

> Gabriel Dos Reis wrote:
> >Would there be a way to systematize these expclicit try-block without
> >efficiency loss (a la RAII or sentry)?
> 
> Yes, RAII is preferred, but I decided to keep within the spirit of what
> was already there to fix this bug rather than rewrite this and
> other sections.

No need to change anything outside that function, see patch.

jon

-- 
"Until they become conscious they will never rebel,
 and until after they have rebelled they cannot become conscious."
	- 1984, George Orwell

Attachment: libstdcxx-rbtree_rollback.patch
Description: Text document

Follow-Ups:
- Re: [libstdc++ PATCH] Fix leak in _Rb_tree::_M_insert (stl_tree.h)
  - From: Paolo Carlini

References:
- [libstdc++ PATCH] Fix leak in _Rb_tree::_M_insert (stl_tree.h)
  - From: Earl Chew
- Re: [libstdc++ PATCH] Fix leak in _Rb_tree::_M_insert (stl_tree.h)
  - From: Gabriel Dos Reis
- Re: [libstdc++ PATCH] Fix leak in _Rb_tree::_M_insert (stl_tree.h)
  - From: Earl Chew

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]