This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups [csl-arm-branch]


Julian Brown wrote:
Hi,

This patch stops entities with vague linkage from being declared as ELF weak symbols when HAVE_GAS_COMDAT_GROUP is true. This is mainly cosmetic, but could lead to subtle interoperability problems.

Tested with cross to arm-none-eabi.

OK to apply?

Is there any reason not to do this in elf.h? It doesn't seem ARM-specific to me. Would you try making that change, and testing on IA32 GNU/Linux as well? Does anyone see backwards compatibility problems here?


--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]