This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] PATCH Fix PR 20058

Steve Kargl wrote:
> @@ -132,6 +136,9 @@
>        gfc_logical_kinds[i_index].kind = kind;
>        gfc_logical_kinds[i_index].bit_size = bitsize;
>  
> +      if (kind > gfc_max_integer_kind)
> +	gfc_max_integer_kind = kind;
> +
>        i_index += 1;
>      }
>  
Minor suggestion: you could just put
  gfc_max_integer_kind = gfc_integer_kinds[i_index - 1].kind;
after the loop because IIUC the loop will always go from lowest bit-width to
largest.

- Tobi
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]