This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR 18785: alternative patch
- From: Roger Sayle <roger at eyesopen dot com>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 14 Feb 2005 18:25:59 -0700 (MST)
- Subject: Re: PR 18785: alternative patch
On Mon, 14 Feb 2005, Zack Weinberg wrote:
> I forgot to mention - since the choice between my patch and Roger's is
> largely a question of design style, I would prefer not to be the
> person who decides which is to go in. Could other interested
> maintainers please comment?
Lacking further comment by other interested maintainers, I think that
your patch should go in. There are many subtleties that are only
understood once you try tackling this problem, and once those are
appreciated/handled there's very little difference between our two
approaches (lang_hook vs. cached lookup table). To your's credit,
you also deprecate/poison TARGET_DIGIT0 and friends, fix the pretty
printers, and update the documentation. (You work to hard :)
To repeat Joseph's point, don't forget to add the testcase and
mention PR middle-end/18785 in the ChangeLog entry when you commit.
Very many thanks again,
Roger
--