This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] testsuite (committed) xfail libstdc++ tests for broken cplxf arg
- From: ja2morri at csclub dot uwaterloo dot ca (James A. Morrison)
- To: Janis Johnson <janis187 at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: 11 Feb 2005 18:00:13 -0500
- Subject: Re: [PATCH] testsuite (committed) xfail libstdc++ tests for broken cplxf arg
- References: <20050211224334.GD6773@us.ibm.com>
Janis Johnson <janis187@us.ibm.com> writes:
> This patch marks some libstdc++ tests as XFAIL if libm on the test
> system was built with a version of GCC that did not have a fix to pass
> complex floats according to the PowerPC-64 ELF ABI.
>
> Tested with -m32 and -m64 on powerpc64-unknown-linux-gnu, on a system
> with an incompatible libm and one with a compatible libm. Checked in
> on mainline.
>
> 2005-02-11 Janis Johnson <janis187@us.ibm.com>
>
> * testsuite/lib/libstdc++.exp: Load target-supports-dg.exp.
> * testsuite/26_numerics/complex/13450.cc: XFAIL for broken_cplxf_arg.
> * testsuite/26_numerics/complex/complex_value.cc: Ditto.
> * testsuite/26_numerics/complex/pow.cc: Ditto.
>
> Index: libstdc++-v3/testsuite/lib/libstdc++.exp
> ===================================================================
> RCS file: /opt/gcc-cvs/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp,v
> retrieving revision 1.31
> diff -u -p -r1.31 libstdc++.exp
> --- libstdc++-v3/testsuite/lib/libstdc++.exp 2 Feb 2005 19:15:01 -0000 1.31
> +++ libstdc++-v3/testsuite/lib/libstdc++.exp 10 Feb 2005 18:43:13 -0000
> @@ -47,6 +47,7 @@ load_lib dg.exp
> load_lib libgloss.exp
> # compiler routines, then ours
> load_gcc_lib target-supports.exp
> +load_gcc_lib target-supports-dg.exp
> load_lib prune.exp
> load_lib dg-options.exp
> load_gcc_lib target-libpath.exp
> Index: libstdc++-v3/testsuite/26_numerics/complex/13450.cc
> ===================================================================
> RCS file: /opt/gcc-cvs/gcc/libstdc++-v3/testsuite/26_numerics/complex/13450.cc,v
> retrieving revision 1.2
> diff -u -p -r1.2 13450.cc
> --- libstdc++-v3/testsuite/26_numerics/complex/13450.cc 11 Mar 2004 19:05:19 -0000 1.2
> +++ libstdc++-v3/testsuite/26_numerics/complex/13450.cc 10 Feb 2005 18:55:00 -0000
> @@ -1,3 +1,5 @@
> +// { dg-do run { xfail { powerpc*-*-linux* && broken_cplxf_arg } } }
> +
> // Copyright (C) 2004 Free Software Foundation
> //
> // This file is part of the GNU ISO C++ Library. This library is free
> Index: libstdc++-v3/testsuite/26_numerics/complex/complex_value.cc
> ===================================================================
> RCS file: /opt/gcc-cvs/gcc/libstdc++-v3/testsuite/26_numerics/complex/complex_value.cc,v
> retrieving revision 1.1
> diff -u -p -r1.1 complex_value.cc
> --- libstdc++-v3/testsuite/26_numerics/complex/complex_value.cc 22 Jun 2004 10:52:14 -0000 1.1
> +++ libstdc++-v3/testsuite/26_numerics/complex/complex_value.cc 10 Feb 2005 18:55:18 -0000
> @@ -1,3 +1,4 @@
> +// { dg-do run { xfail { powerpc*-*-linux* && broken_cplxf_arg } } }
> // { dg-options "-O0" }
> // 2000-11-20
> // Benjamin Kosnik bkoz@redhat.com
> Index: libstdc++-v3/testsuite/26_numerics/complex/pow.cc
> ===================================================================
> RCS file: /opt/gcc-cvs/gcc/libstdc++-v3/testsuite/26_numerics/complex/pow.cc,v
> retrieving revision 1.2
> diff -u -p -r1.2 pow.cc
> --- libstdc++-v3/testsuite/26_numerics/complex/pow.cc 5 Dec 2004 00:26:16 -0000 1.2
> +++ libstdc++-v3/testsuite/26_numerics/complex/pow.cc 10 Feb 2005 18:55:36 -0000
> @@ -1,3 +1,4 @@
> +// { dg-do run { xfail { powerpc*-*-linux* && broken_cplxf_arg } } }
Shouldn't this be xfail { broken_cplxf_arg } ?
> // PR libstdc++/10689
> // Origin: Daniel.Levine@jhuaph.edu
> // { dg-options "-mieee" { target alpha*-*-* } }
>
--
Thanks,
Jim
http://www.student.cs.uwaterloo.ca/~ja2morri/
http://phython.blogspot.com
http://open.nit.ca/wiki/?page=jim