Re: [PATCH] fixincl.c missing prototypes

[Marcin Dalecki <martin at dalecki dot de>]

On 2005-01-31, at 22:41, Geoffrey Keating wrote:

> Marcin Dalecki <martin@dalecki.de> writes:
>
> > This is fixing some missing prototypes in the file mentioned in 
> > subject.
> >
> > diff -urN gcc-4.0-20050123/fixincludes/fixincl.c
> > gcc-4.0-20050123-new/fixincludes/fixincl.c
> > --- gcc-4.0-20050123/fixincludes/fixincl.c	Wed Nov 17 06:06:41 2004
> > +++ gcc-4.0-20050123-new/fixincludes/fixincl.c	Wed Jan 26 07:01:56 
> > 2005
> > @@ -30,6 +30,9 @@
> >   #define  BAD_ADDR ((void*)-1)
> >   #endif
> >
> > +#include <sys/types.h>
> > +#include <sys/wait.h>
> > +
> >   #ifndef SEPARATE_FIX_PROC
> >   #include "server.h"
> >   #endif
>
> I believe you need to wrap these with HAVE_SYS_TYPES_H and
> HAVE_SYS_WAIT_H, and then use autoconf to get those defined.

I checked against another places where those get included.
They where not guared. Thus I assumed that since those headers are
pretty standard where GCC compiles this should be not needed.
However I can check whatever there is maybe an overall miss of the
required autoconf header check.