This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: pattern bugs in 64-bit Darwin
- From: Geoffrey Keating <geoffk at geoffk dot org>
- To: Dale Johannesen <dalej at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 31 Jan 2005 13:38:35 -0800
- Subject: Re: Patch: pattern bugs in 64-bit Darwin
- References: <156cdd34a008512bf90ce31662293bb5@apple.com>
Dale Johannesen <dalej@apple.com> writes:
> These two are obvious porting errors introduced when copying the 32-bit
> patterns. There are more 64-bit Darwin changes coming. Bootstrapped
> and
> tested.
>
> 2005-01-30 Dale Johannesen <dalej@apple.com>
>
> * config/rs6000/darwin.md (movsf_low_di): Make work.
> (movdf_low_di): Make work.
This is OK, but:
> case 1:
> - {
> - rtx operands2[4];
> - operands2[0] = operands[0];
> - operands2[1] = operands[1];
> - operands2[2] = operands[2];
> - if (TARGET_POWERPC64 && TARGET_32BIT)
> - /* Note, old assemblers didn't support relocation here. */
> return \"ld %0,lo16(%2)(%1)\";
Please fix the indenting on this line.