This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] missing protoypes in dummy-conditions.c
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Marcin Dalecki <martin at dalecki dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 31 Jan 2005 13:32:51 +0000 (UTC)
- Subject: Re: [PATCH] missing protoypes in dummy-conditions.c
- References: <888972c99d4ad3a0c2de27f57cb57b52@dalecki.de>
On Mon, 31 Jan 2005, Marcin Dalecki wrote:
> This is removing some struct redeclarations tricks which are recipe
> for failure. The removed comment basically explains itself as a bad idea.
I don't see the problem. The struct definition is the same as in
gensupport.h. Including many extra headers as your patch does risks
breaking bootstrap with non-GCC which might expect all functions called
from any inline functions defined in those headers or headers included
directly or indirectly from them to be defined in generator programs, see
<http://gcc.gnu.org/ml/gcc-patches/2005-01/msg01664.html>.
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
joseph@codesourcery.com (CodeSourcery mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)