This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Another patch for bad warnings for inlined functions


On Thu, 2005-01-27 at 22:29 -0500, Ian Lance Taylor wrote:
> There is a new test case in PR 19583 which produces another
> undesirable warning about an inlined function not returning a value.
> 
> This patch fixes it.  I think this patch is correct based on the
> semantics of TRY_FINALLY_EXPR: if the try clause does not fall
> through, then even if the finally clause falls through, the whole
> expression is not going to fall through--it is going to resume
> execution at the point whereever the try clause went to.
> 
> This does not introduce any new testsuite failures on
> i686-pc-linux-gnu.  OK to commit if it passes a bootstrap?
> 
> Ian
> 
> 
> 2005-01-27  Ian Lance Taylor  <ian@airs.com>
> 
> 	* gimple-low.c (block_may_fallthru): TRY_FINALLY_EXPR only falls
> 	through if both operands fall through.
This is fine.  Though I would suggest a comment explaining why both
the TRY and FINALLY must fall through.

If you could add a test to the testsuite it would appreciated.

jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]