This is the mail archive of the
mailing list for the GCC project.
Re: Another patch for bad warnings for inlined functions
- From: Jeffrey A Law <law at redhat dot com>
- To: Ian Lance Taylor <ian at airs dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 28 Jan 2005 10:15:30 -0700
- Subject: Re: Another patch for bad warnings for inlined functions
- Organization: Red Hat, Inc
- References: <email@example.com>
- Reply-to: law at redhat dot com
On Thu, 2005-01-27 at 22:29 -0500, Ian Lance Taylor wrote:
> There is a new test case in PR 19583 which produces another
> undesirable warning about an inlined function not returning a value.
> This patch fixes it. I think this patch is correct based on the
> semantics of TRY_FINALLY_EXPR: if the try clause does not fall
> through, then even if the finally clause falls through, the whole
> expression is not going to fall through--it is going to resume
> execution at the point whereever the try clause went to.
> This does not introduce any new testsuite failures on
> i686-pc-linux-gnu. OK to commit if it passes a bootstrap?
> 2005-01-27 Ian Lance Taylor <firstname.lastname@example.org>
> * gimple-low.c (block_may_fallthru): TRY_FINALLY_EXPR only falls
> through if both operands fall through.
This is fine. Though I would suggest a comment explaining why both
the TRY and FINALLY must fall through.
If you could add a test to the testsuite it would appreciated.