This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR debug/19345




On Thu, 27 Jan 2005, Daniel Berlin wrote:



On Wed, 26 Jan 2005, Mark Mitchell wrote:

Daniel Berlin wrote:

Rather than add a null check in decl_function_context, i've simply guarded against calling it here with null (we already were assuming it could return null, so what's 2 null checks when you've already got 1 :P).
Everything else DTRT once we exit our if block.


Bootstrapped and regtested on i686-pc-linux-gnu. Okay for mainline?

That doesn't seem right to me, as this type is indeed local to a function. I'd say that DECL_CONTEXT applied to the type should indeed be a FUNCTION_DECL.

It is.


See dwarf2out.c add_abstract_origin_attribute
The if part this code is in is just trying to make sure the containing function
s/containing function/origin type/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]