This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH for 3.4/4.0] Fix PR14479, 19487 (reject valid anonymous enum)


Kriang Lerdsuwanakij <lerdsuwa@users.sf.net> wrote:

>> In the new parser, we already have cp_parser_check_template_parameters
>> that do the same thing.  So the function maybe_check_template_type,
>> only used in one place in the front-end, is considered redundant
>> and can be removed completely.


Since you are it, can you tweak a little cp_parser_check_template_parameters
to be more informative and mention something about its context (%qT of the
template would help for instance)? This is especially useful for nested
templates and in case of preprocessor abuse (quite common nowadays).
-- 
Giovanni Bajo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]