This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Change to gcc.dg/tree-ssa/loop-1.c


> > You should get an XFAIL (maybe an XPASS on hppa elf targets if they have
> > no external declarations) but no FAIL and no ERROR using the latest
> > version of this test case.
> 
> We now have an XFAIL on SOM and an XPASS on ELF.  I don't see this as
> progress as the XPASS isn't unexpected.
> 
> Dave

I didn't realize we would get any XPASS's but I only tested the HP-UX
targets.  I don't see any way to get rid of both the XPASS's and XFAIL's
without using if statements which Janis Johnson didn't want me doing.
See the discussion starting at:

	http://gcc.gnu.org/ml/gcc-patches/2005-01/msg00545.html
	

How about the following patch (untested), it should get rid of the
XPASS's and leave only some XFAIL's by checking for hppa*-*-hpux*
instead of hppa*-*-*:


2005-01-21  Steve Ellcey  <sje@cup.hp.com>

	* gcc.dg/tree-ssa/loop-1.c:  Fix target names for hppa.


*** gcc.orig/gcc/testsuite/gcc.dg/tree-ssa/loop-1.c	Fri Jan 21 08:42:04 2005
--- gcc/gcc/testsuite/gcc.dg/tree-ssa/loop-1.c	Fri Jan 21 08:42:38 2005
*************** void xxx(void)
*** 29,36 ****
     well as the calls we need to look for something more specific then just
     foo in order to count only the calls and not the declaration.  */
  
! /* { dg-final { scan-assembler-times "foo" 5 { xfail hppa*-*-* ia64*-*-* } } } */
! /* { dg-final { scan-assembler-times "foo,%r" 5 { target hppa*-*-* } } } */
  /* { dg-final { scan-assembler-times "= foo"  5 { target ia64*-*-* } } } */
  
  
--- 29,36 ----
     well as the calls we need to look for something more specific then just
     foo in order to count only the calls and not the declaration.  */
  
! /* { dg-final { scan-assembler-times "foo" 5 { xfail hppa*-*-hpux* ia64*-*-* } } } */
! /* { dg-final { scan-assembler-times "foo,%r" 5 { target hppa*-*-hpux* } } } */
  /* { dg-final { scan-assembler-times "= foo"  5 { target ia64*-*-* } } } */
  
  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]