This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Committed: Fix typo in gcc.dg/tree-ssa/loop-1.c


> Without this correction, I see:
> ERROR: gcc.dg/tree-ssa/loop-1.c: error executing dg-final: scan-assembler: too many arguments
> People testing their changes before committing, would presumably
> see it too.  Thankfully this isn't the type of typo that ruins a
> whole test-run...  However, it's just as easily checked as any
> other change to a single test-case.

Sorry about that.  I did test it but I didn't examine the results of the
testing closely enough.  I just looked to see it didn't show up on the
FAIL list anymore (which it didn't) but I did not see that it showed up
as an unresolved test.  Individual unresolved tests get listed in the
log file but not in output of the 'make check'.

I now see there is a second bug in my patch that will affect hppa runs
and I will check in the following change as an obvious fix.


2005-01-20  Steve Ellcey  <sje@cup.hp.com>

	* gcc.dg/tree-ssa/loop-1.c:  Fix target names on xfail.


*** gcc.orig/gcc/testsuite/gcc.dg/tree-ssa/loop-1.c	Thu Jan 20 08:19:54 2005
--- gcc/gcc/testsuite/gcc.dg/tree-ssa/loop-1.c	Thu Jan 20 08:20:23 2005
*************** void xxx(void)
*** 29,35 ****
     well as the calls we need to look for something more specific then just
     foo in order to count only the calls and not the declaration.  */
  
! /* { dg-final { scan-assembler-times "foo" 5 { xfail hppa-*-* ia64-*-* } } } */
  /* { dg-final { scan-assembler-times "foo,%r" 5 { target hppa*-*-* } } } */
  /* { dg-final { scan-assembler-times "= foo"  5 { target ia64*-*-* } } } */
  
--- 29,35 ----
     well as the calls we need to look for something more specific then just
     foo in order to count only the calls and not the declaration.  */
  
! /* { dg-final { scan-assembler-times "foo" 5 { xfail hppa*-*-* ia64*-*-* } } } */
  /* { dg-final { scan-assembler-times "foo,%r" 5 { target hppa*-*-* } } } */
  /* { dg-final { scan-assembler-times "= foo"  5 { target ia64*-*-* } } } */
  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]