This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Merge PHI nodes. (Take 2)


On Wed, 2005-01-19 at 00:55 -0500, Kazu Hirata wrote:
> +
> +  /* If the destination block consists of an nonlocal label, do not merge
> +     it.  */
> +  label = first_stmt (dest);
> +  if (label
> +      && TREE_CODE (label) == LABEL_EXPR
> +      && DECL_NONLOCAL (LABEL_EXPR_LABEL (label)))
> +    return;
Note that I don't think this is safe until we have fixed the root causes
for the checking failures exposed by your patch to verify that nonlocal
labels don't appear in the middle of a basic block.

I think that should be turned into a suitable loop until such time
as we've fixed our problems with nonlocals appearing in the middle
of blocks.

With that change this is OK.

Thanks,
jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]