This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR target/18916; Function arg passing mem align fixes.


On Jan 18, 2005, Alan Modra <amodra@bigpond.net.au> wrote:

> On Tue, Jan 18, 2005 at 12:23:53PM -0200, Alexandre Oliva wrote:
>> I just feared the proposed change would break that.

> It shouldn't do. :)   One thing that concerned me a little is that we
> may generate worse code in some cases.  If a target has an ABI that
> passes function parms on the stack without aligning to normal alignment
> for the type, but the alignment is sufficient for all generated code,
> then the new code in assign_parm_adjust_stack_rtl will unnecessarily
> generate a new aligned stack temp for the parm.  This results in an
> unnecessary copy.

Excellent.  I'll add to my LINO (*) todo-list an item to look into
whether we can take advantage of this copy to enable double-word loads
and stores in general.

Thanks!

* Last in, never out :-)

-- 
Alexandre Oliva             http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]