This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix digest_init vector handling (PRs middle-end/19164,c/17297)


Jakub Jelinek wrote:
Hi!

PR middle-end/19164 ICEs because digest_init handles assumes there is a
CONSTRUCTOR while there is actually a NOP_EXPR <INTEGER_CST> (or there
can be VECTOR_CST etc.).

PR c/17297 fails because although the constructor is TREE_CONSTANT,
it contains TREE_CONSTANT RDIV_EXPRs (division by 0), but everything
in the compiler expects VECTOR_CST to only contain *_CSTs.

Ok to commit if testing succeeds, both to HEAD and 3.4?

Yes, this OK.


I've run into this mess before in other contexts. I can't remember why we allow division by zero in the input program; perhaps the standards say that this is undefined behavior only if the program actually reaches this point?

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]