This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Avoid using BB_VISITED everywhere


On Sun, 2005-01-09 at 02:03 +0100, Steven Bosscher wrote:
> Hi,
> 
> Following the discussion on gcc@, this patch documents that BB_VISITED
> is not supposed to be used by any pass.
> 
> Bootstrapped and tested on {i686,x86_64,ia64,ppc64,ppc)-suse-linux-gnu.
> OK?

> ! #define BB_VISITED		8	/* Used by dfs_enumerate_from().  */
Nit -- when referring to function names in documentation and comments,
do not include '()'.  

It is also considered more appropriate to put the comments before the
definitions rather than on the same line as the #define.  

The remainder of the patch is approved with those two nits fixed.

Thanks,
Jeff




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]