This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PR19090] Add -Wno-pointer-sign option


On Sun, 17 Jan 2005, Andi Kleen wrote:

> On Sun, Jan 16, 2005 at 10:35:10PM +0000, Joseph S. Myers wrote:
> > On Fri, 14 Jan 2005, Andi Kleen wrote:
> > 
> > > --- gcc/doc/invoke.texi	11 Jan 2005 10:15:32 -0000	1.566
> > > +++ gcc/doc/invoke.texi	14 Jan 2005 06:50:34 -0000
> > 
> > You need to update the summary table of C warning options as well as 
> > documenting this individual option below.
> 
> Can you approve the patch when I do this change? 

Only with testcase.  A testcase is required so that, for example, if the 
code in question is rewritten the effects of this option aren't 
accidentally lost.  Every warning option should have thorough tests for 
its effect.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]