This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [PR19090] Add -Wno-pointer-sign option


On Sun, Jan 16, 2005 at 10:35:10PM +0000, Joseph S. Myers wrote:
> On Fri, 14 Jan 2005, Andi Kleen wrote:
> 
> > --- gcc/doc/invoke.texi	11 Jan 2005 10:15:32 -0000	1.566
> > +++ gcc/doc/invoke.texi	14 Jan 2005 06:50:34 -0000
> 
> You need to update the summary table of C warning options as well as 
> documenting this individual option below.

Can you approve the patch when I do this change? 

> > +@item -Wno-pointer-sign
> > +@opindex Wno-pointer-sign
> > +Don't warn for pointer argument passing or assignment with different signedness.
> > +Only useful in the negative form since this warning is enabled by default.
> > +This option is only supported for C and Objective C.
> 
> "Objective-C", not "Objective C", and the last sentence should end "@." 
> because of the capital letter at the end, to get correct spacing if any 
> more sentences are added after it.

I'll leave that whoever adds more sentences. Not that it's very likely
that this option will be a hotrod of new development in the future :)

> 
> In addition, this patch needs a testcase for the option, probably a copy 
> of gcc.dg/conv-2.c with dg-options "-Wno-pointer-sign" added and all the 
> dg-warning annotations removed.

I considered writing a test case for no warning when I did the patch and it seemed 
completely pointless to me. I still think that's still the case.

-Andi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]