This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-profiling-branch PATCH IPCP extensions + Function cloning


On Sunday 16 January 2005 15:15, Razya Ladelsky wrote:

> > Also it would be really cool to share at least partly this with the
> > copy_decl_for_inlining
>
> Sharing the code means that we would have to add another flag, saying
> whether we are
> versioning or inlining. This will require to add another argument to all
> calls
> to copy_decl_for_inlining(), and we wanted to minimize changes in existing
> code.

I would prefer the proper design over minimizing the number of changes.
You can do most of the changes incrementally.  For example you could 
already sumbit relatively independent changes piece-by-piece and merge
then into the branch.  Then the larger, "new-stuff" patches don't seem
so intrusive anymore.

Duplicating code is *bad*.

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]