This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: move2add_note_store: handle subregs


Hi Aldy,

On Thu, 13 Jan 2005, Aldy Hernandez wrote:
>     if (SCALAR_INT_MODE_P (mode)
>         && hard_regno_nregs[regno][mode] == 1 && GET_CODE (set) == SET
>         && GET_CODE (SET_DEST (set)) != ZERO_EXTRACT
> !       && GET_CODE (SET_DEST (set)) != STRICT_LOW_PART
> !       && !subreg_p)
>       {
>         rtx src = SET_SRC (set);
>         rtx base_reg;

Just an observation, but the prevailing idiom in the existing code
would suggest the use of

>         && GET_CODE (SET_DEST (set)) != ZERO_EXTRACT
> !       && GET_CODE (SET_DEST (set)) != STRICT_LOW_PART
> !       && GET_CODE (SET_DEST (set)) != SUBREG)

instead of your proposal to introduce a new subreg_p Boolean variable.


Roger
--


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]