This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR middle-end/18820
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: Eric Botcazou <ebotcazou at libertysurf dot fr>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 10 Jan 2005 10:27:04 -0500
- Subject: Re: [PATCH] Fix PR middle-end/18820
- References: <200501101346.17886.ebotcazou@libertysurf.fr>
On Jan 10, 2005, at 7:52 AM, Eric Botcazou wrote:
Hi,
This is the ACATS c953002 failure. The problem was introduced with:
2004-11-03 Andrew Pinski <pinskia@physics.uc.edu>
PR tree-opt/18231
* tree.c (staticp) <case FUNCTION_DECL>: Nested functions are static
also.
Woops I had meant to figure out a testcase but I never got around to it.
The following is the testcase:
int f (int i)
{
auto inline __attribute__ ((always_inline)) int h (int i) { return i;
}
auto inline __attribute__ ((always_inline)) int g (void) { return h
(i); }
return g ();
}
But since we don't error out even though h is not inlined.
Reverting this patch will break glibc. If I were you any further patch
which changes stuff related to nested functions be tested also against
glibc since that is one software which uses nested function to the max.
Thanks,
Andrew Pinski