This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping^2


On Tue, 4 Jan 2005, Joern RENNECKE wrote:
> Kaz Kojima wrote:
> >+#if defined (MODE_ENTRY) && defined (MODE_EXIT)
> >+/* Split the edge from the entry block and the fallthrough edge to the
> >+   exit block, so that we can note that there NORMAL_MODE is supplied /
> >+   required.  Return the new block if it's inserted before the exit
> >+   block.  Otherwise return null.  */
> >
>
> That comment has to be split.  Where post_entry is set, you need:
>
> /* Split the edge from the entry block, so that we can note that
>    there NORMAL_MODE is supplied.  */
>
> And for the new function:
> /* Split the fallthrough edge to the exit block, so that we can note
>    that there NORMAL_MODE is required.  Return the new block if it's
>    inserted before the exit block.  Otherwise return null.  */
>
> Otherwise, that patch is fine with me.

As Joern's happy with the revised patch, it's OK for mainline with
the comment he's changes suggested above.  But don't forget to list
PR target/16482 in the ChangeLog entry.

I'll leave it to the folks actually writing the patches to decide
whether they want to commit this fix now and implement Joern's larger
"consolidation" clean-up as a follow-up patch, or to instead prepare
a "take 3".

Thanks again to you both,

Roger
--


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]