This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR19100: truthvalue_conversion vs. TREE_OVERFLOW (take3)


On Mon, 3 Jan 2005, Roger Sayle wrote:

> I'm not sure whether to interpret your response as implicit approval,
> as all of the current tests in the testsuite continue to pass, or as
> a request to improve testsuite coverage of C and C++'s diagnostics.
> PR19100 is a wrong-code bug after all.

A request to improve coverage of those specific diagnostics for implicit 
constant conversions (not the other diagnostics for overflow in 
arithmetic), for better assurance that fixing this bug isn't causing a 
regression elsewhere.  I don't like relying on bootstrap to test this or 
that part of the compiler when the code in question might change so it no 
longer exercises those parts of the compiler it did previously and when 
this may test the absence of diagnostics in some cases but not their 
presence when they should appear.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]