This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] PR19100: truthvalue_conversion vs. TREE_OVERFLOW (take3)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>
- Date: Mon, 3 Jan 2005 18:49:28 +0000 (UTC)
- Subject: Re: [PATCH] PR19100: truthvalue_conversion vs. TREE_OVERFLOW (take3)
- References: <Pine.LNX.email@example.com>
On Mon, 3 Jan 2005, Roger Sayle wrote:
> I'm not sure whether to interpret your response as implicit approval,
> as all of the current tests in the testsuite continue to pass, or as
> a request to improve testsuite coverage of C and C++'s diagnostics.
> PR19100 is a wrong-code bug after all.
A request to improve coverage of those specific diagnostics for implicit
constant conversions (not the other diagnostics for overflow in
arithmetic), for better assurance that fixing this bug isn't causing a
regression elsewhere. I don't like relying on bootstrap to test this or
that part of the compiler when the code in question might change so it no
longer exercises those parts of the compiler it did previously and when
this may test the absence of diagnostics in some cases but not their
presence when they should appear.
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
firstname.lastname@example.org (personal mail)
email@example.com (CodeSourcery mail)
firstname.lastname@example.org (Bugzilla assignments and CCs)