This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] PR19100: truthvalue_conversion vs. TREE_OVERFLOW (take3)
Joseph S. Myers wrote:
On Sat, 1 Jan 2005, Roger Sayle wrote:
* c-common.c (convert_and_check): Avoid testing TREE_OVERFLOW to
detect conversion overflow, instead use int_fits_type_p.
I don't think there's presently adequate testsuite coverage for the
diagnostics for overflow in implicit constant conversions. (There isn't
*any* coverage for the diagnostics for overflow in arithmetic, but I think
properly testing that the diagnostics for implicit conversions don't
change or only change to fix bugs would suffice for this patch.)
To be clear, are you asking Roger to write those additional tests? Or,
are you just commenting about the lack of tests?