This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR target/19211, Ada bootstrap failure on ppc-darwin

From: Dale Johannesen <dalej at apple dot com>
To: Andrew Pinski <pinskia at physics dot uc dot edu>
Cc: Dale Johannesen <dalej at apple dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 31 Dec 2004 12:24:18 -0800
Subject: Re: [PATCH] Fix PR target/19211, Ada bootstrap failure on ppc-darwin
References: <E8F51761-5ADD-11D9-8F73-000A95D692F4@physics.uc.edu>

On Dec 30, 2004, at 7:41 PM, Andrew Pinski wrote:

ChangeLog:

	* config/darwin.c (machopic_legitimize_pic_address): If the orig
	is subregister return orig.

<tt.diff.txt>

OK, but... it's annoyingly asymmetrical to use REG_P but GET_CODE()==SUBREG. It would be better either to add SUBREG_P or use GET_CODE()==REG IMO. The latter change is approved if you want to go that way; I cannot approve adding things to rtl.h though.

References:
- [PATCH] Fix PR target/19211, Ada bootstrap failure on ppc-darwin
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]