Re: [patch] Don't forget to pop timevar

[Mark Mitchell <mark at codesourcery dot com>]

Gabriel Dos Reis wrote:
> Mark Mitchell <mark@codesourcery.com> writes:
>
> | Gabriel Dos Reis wrote:
> | > Volker Reichelt <reichelt@igpm.rwth-aachen.de> writes:
> | > | Right at the beginning of the function pushtag in cp/name-lookup.c
> | > | we have "timevar_push (TV_NAME_LOOKUP);". However, we leave the
> | > | function in one path without popping the variable again. Only
> | > | mainline is affected.
> | > | | The following patch fixes that.
> | > | | Ok to commit once bootstrapping and regtesting succeeded?
> | > I think the patch qualifies as obvious, and being the perpetrator of
> | > POP_TIMEVAR_AND_RETURN I believe the patch is fine.  And it fixes a
> | > bug (my understanding is that we're back to bug-fixing mode).
> | 
> | No, we're not, unless I announced that without remembering it.  It's
>
> I got that understanding from your fellow sourcerer
>
>    http://gcc.gnu.org/ml/gcc-patches/2004-12/msg01647.html

He's confused.  It happens, even to us. :-)

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304