This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR C++/18984



On Dec 21, 2004, at 3:17 PM, Mark Mitchell wrote:


Andrew Pinski wrote:
The code was like this before, I am only changing where we call
poiner_set_insert and nothing else.

That doesn't make sense. If STMT is not a CLEANUP_STMT, then using CLEANUP_BODY isn't correct.

Maybe you miss: else if (TREE_CODE (stmt) == CLEANUP_STMT)

I also reformatted the line under the else if, maybe that is what you
missed.

So the code looks like this after the patch is applied:

  else if (TREE_CODE (stmt) == CLEANUP_STMT)
    *stmt_p = build2 (CLEANUP_EH_ONLY (stmt) ? TRY_CATCH_EXPR
                                             : TRY_FINALLY_EXPR,
                      void_type_node,
                      CLEANUP_BODY (stmt),
                      CLEANUP_EXPR (stmt));

pointer_set_insert (p_set, *stmt_p);

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]