This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR 18965, a c++ and gimplifier fix

On Friday 17 December 2004 07:25, Richard Henderson wrote:
> Please pull all of this out into a subroutine.

Yeah, if you do that it looks a *lot* prettier than what I attached
for this to PR18191.  Thanks Andrew for posting this.


> > +		    var = var +1;
> > +		    if (var > upper) break;
>
> Fails if upper = TYPE_MAX_VALUE (type).  It may or may not be most
> efficient if you special case TYPE_MAX_VALUE
>
> 		if (var == upper) goto out;
> 		var = var + 1;
> 		goto loop;

I like this one best.

With my hack PR18191 was fixed.  When a new version of this patch
is available I'll retest it combined with my patch.

Gr.
Steven
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]