This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: Fix PR middle-end/18590
- From: Richard Henderson <rth at redhat dot com>
- To: Bernardo Innocenti <bernie at develer dot com>
- Cc: Eric Botcazou <ebotcazou at libertysurf dot fr>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 14 Dec 2004 15:52:07 -0800
- Subject: Re: PING: Fix PR middle-end/18590
- References: <200412060903.36970.ebotcazou@libertysurf.fr> <41BD6344.8060503@develer.com>
On Mon, Dec 13, 2004 at 10:39:16AM +0100, Bernardo Innocenti wrote:
> Eric Botcazou wrote:
>
> >2004-12-05 Eric Botcazou <ebotcazou@libertysurf.fr>
> >
> > Fix PR middle-end/18590
> > * function.c (fixup_var_refs_insns_with_hash): Do not invoke
> > fixup_var_refs_insn on insns marked as deleted if optimization
> > is enabled.
>
> This patch is still unreviewed. I'd like it to be also backported to
> 3.4 to fix this m68k ICE.
>
>
> >Index: function.c
> >===================================================================
> >RCS file: /cvs/gcc/gcc/gcc/function.c,v
> >retrieving revision 1.483.4.19
> >diff -u -p -r1.483.4.19 function.c
> >--- function.c 13 Oct 2004 23:18:13 -0000 1.483.4.19
> >+++ function.c 1 Dec 2004 13:02:19 -0000
> >@@ -1639,7 +1639,8 @@ fixup_var_refs_insns_with_hash (htab_t h
> > tmp.key = var;
> > ime = htab_find (ht, &tmp);
> > for (insn_list = ime->insns; insn_list != 0; insn_list = XEXP
> > (insn_list, 1))
> >- if (INSN_P (XEXP (insn_list, 0)))
> >+ if (INSN_P (XEXP (insn_list, 0))
> >+ && !(optimize && INSN_DELETED_P (XEXP (insn_list, 0))))
Seems to me that we should mind INSN_DELETED_P regardless of optimize.
r~