This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.1 patch] Delete old #if 0 code in reload
- From: Ian Lance Taylor <ian at airs dot com>
- To: neroden at fastmail dot fm (Nathanael Nerode)
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 14 Dec 2004 14:57:34 -0500
- Subject: Re: [4.1 patch] Delete old #if 0 code in reload
- References: <20041214184419.GA14871@fastmail.fm>
neroden@fastmail.fm (Nathanael Nerode) writes:
> So I was getting a little tired of the presence of old disabled code.
>
> Should any of this be kept?
>
> Or is the OK for 4.1?
>
> * reload.c: Remove code #if 0-ed out in 2000 or earlier.
> * reload1.c: Remove code #if 0-ed out in 2000 or earlier.
Normally I think #if 0 code is useless. However, reload may be an
exception. Since the code in reload is baroque and confusing, it can
sometimes help to see that something was tried and then removed. It
means that the developer knows to not bother trying that code again.
Of course, a carefully written comment can have the same effect. So I
think that if we remove the #if 0 code in reload, we should try to
replace it with intelligent comments.
Ian