This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR bootstrap/18532: libgcc.mk isn't parallel build safe for multilib
- From: Richard Earnshaw <Richard dot Earnshaw at buzzard dot freeserve dot co dot uk>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: "H. J. Lu" <hjl at lucon dot org>, gcc-patches at gcc dot gnu dot org, Richard dot Earnshaw at buzzard dot freeserve dot co dot uk
- Date: Thu, 02 Dec 2004 22:56:13 +0000
- Subject: Re: PATCH: PR bootstrap/18532: libgcc.mk isn't parallel build safe for multilib
- References: <87653kh0ei.fsf@codesourcery.com>
On Thu, 02 Dec 2004 13:10:13 PST, Zack Weinberg wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
>
> > On Thu, Dec 02, 2004 at 12:58:12PM -0800, Zack Weinberg wrote:
> >> "H. J. Lu" <hjl@lucon.org> writes:
> >>
> >> > Here are the updated patch and the libgcc.mk diff.
> >> >
> >> > H.J.
> >> > ----
> >> > 2004-12-02 H.J. Lu <hongjiu.lu@intel.com>
> >> >
> >> > PR bootstrap/18532
> >> > * mklibgcc.in: Build one set of EXTRA_MULTILIB_PARTS for
> >> > multilib at a time. Don't build the default set. Don't add
> >> > EXTRA_MULTILIB_PARTS to shared libunwind nor libgcc. Remove
> >> > filter for shared libunwind and libgcc.
> >>
> >> Only remaining problem that I see is that you lost the dependencies of
> >> libgcc_s.so and libunwind.so on the relevant extra$suffix target. OK
> >> with that put back in.
> >
> > I don't believe they are needed. libgcc_s.so and libunwind.so don't
> > use EXTRA_MULTILIB_PARTS. The "all" target depends on
> > EXTRA_MULTILIB_PARTS. Did I miss something?
>
> EXTRA_MULTILIB_PARTS tend to be the crt* files. Some of those are
> often implicitly used by the link command for a shared library.
This patch has broken the build for an arm-elf cross. We no-longer build
crt<xxx>.o for the default multilib.
R.