This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch: remove '-fnew-verifier'


Here's the patch to remove '-fnew-verifier' as we discussed on the gcj
list.  For those not following the discussion, this is required by
-findirect-dispatch, and we don't want to support this command-line
option into the future.

It is unclear to me whether this can go in now.  It doesn't fix a
regression, but on the other hand avoids putting us in a bad position
later on.

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* lang.c (flag_new_verifier): Define.
	(java_post_options): Set flag_new_verifier if indirect dispatch
	is being used.
	* lang.opt (fnew-verifier): Removed.

Index: lang.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/lang.c,v
retrieving revision 1.165
diff -u -r1.165 lang.c
--- lang.c 25 Nov 2004 03:46:40 -0000 1.165
+++ lang.c 1 Dec 2004 17:11:54 -0000
@@ -139,6 +139,9 @@
 /* Don't attempt to verify invocations.  */
 int flag_verify_invocations = 0; 
 
+/* True if the new bytecode verifier should be used.  */
+int flag_new_verifier = 0;
+
 /* When nonzero, print extra version information.  */
 static int v_flag = 0;
 
@@ -608,6 +611,12 @@
      must always verify everything.  */
   if (! flag_indirect_dispatch)
     flag_verify_invocations = true;
+  else
+    {
+      /* If we are using indirect dispatch, then we want the new
+	 verifier as well.  */
+      flag_new_verifier = 1;
+    }
 
   /* Open input file.  */
 
Index: lang.opt
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/lang.opt,v
retrieving revision 1.12
diff -u -r1.12 lang.opt
--- lang.opt 25 Nov 2004 03:46:40 -0000 1.12
+++ lang.opt 1 Dec 2004 17:11:54 -0000
@@ -176,9 +176,5 @@
 Java Var(flag_use_divide_subroutine) Init(1)
 Call a library routine to do integer divisions
 
-fnew-verifier
-Java Var(flag_new_verifier)
-Enable the new bytecode verifier
-
 version
 Java


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]