This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR 18725, ICE with trivial invalid inline-asm


On Mon, Nov 29, 2004 at 02:43:47PM -0500, Diego Novillo wrote:
> On Mon, 2004-11-29 at 13:59 -0500, Andrew Pinski wrote:
> 
> > 	* tree-cfg.c (tree_node_can_be_shared): Error_mark_node can be
> > 	shared always.
> > 
> Just add it at the end of the first if() in the function.
> error_mark_node will rarely show up.
> 
> OK with that change.

Except he didn't actually compile-test that.  Shame, shame.


r~


        * tree-cfg.c (tree_node_can_be_shared): Fix typo'd error_mark_node.

Index: tree-cfg.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/tree-cfg.c,v
retrieving revision 2.127
retrieving revision 2.128
diff -c -p -d -u -r2.127 -r2.128
--- tree-cfg.c	29 Nov 2004 20:36:32 -0000	2.127
+++ tree-cfg.c	29 Nov 2004 21:06:11 -0000	2.128
@@ -3427,7 +3427,7 @@ tree_node_can_be_shared (tree t)
       || CONSTANT_CLASS_P (t)
       || is_gimple_min_invariant (t)
       || TREE_CODE (t) == SSA_NAME
-      || t == error_node_mark)
+      || t == error_mark_node)
     return true;
 
   if (TREE_CODE (t) == CASE_LABEL_EXPR)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]