This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RS6000] Fix PR12817


On Nov 26, 2004, at 4:00 PM, Alan Modra wrote:
On Fri, Nov 26, 2004 at 06:31:58PM -0500, David Edelsohn wrote:
Alan Modra writes:

PR target/12817 * config/rs6000/rs6000.c (rs6000_emit_prologue): Use r11 for vrsave.

Alan> Bootstrap and regression test powerpc-linux in progress. This ought to
Alan> count as obvious, but I'll ask. OK to install? gcc-3.4 and gcc-3.3
Alan> too?


	This looks okay, but rs6000_emit_prologue is becoming quite
incomprehensible now.

Yes, I think we would do well to split the function into separate ones for each major ABI.

I tried this a year or so ago and gave up. It doesn't actually help with the
comprehensibility all that much, and introduces a lot of duplicated code
as well. But maybe you can do better.


If you do it you should do rs6000_emit_epilogue as well.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]