This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [web,cfo] project page for cfo-branch


On Fri, 26 Nov 2004, [ISO-8859-2] Gábor Lóki wrote:
> Is it OK to commit?

Nearly. ;-)

Please consider the following remarks and apply the resulting patch
after sending it to gcc-patches (without waiting for further approval).

Index: wwwdocs/htdocs/cvs.html
===================================================================
+  motion and merging algorithms). Messages should be marked with <code>
+  [cfo]</code> in the subject line. The usual contribution and testing 
+  rules apply.</dd>

I believe this line break will create an "artificial" blank before
[cfo]; it might be better to move <code> to the next line, directly
before [cfo].

+++ wwwdocs/htdocs/projects/cfo.html	2004-11-23 09:12:28.000000000 +0100
+<hr />
+<h3><a name="intro">Introduction</a></h3>

This, and Documentation should be <h2>, like the News section.  In both
cases I would prefer to omit the <hr />.

+<p>The goal of this project is to add a new extension for improving the code
+size optimization of GCC with code factoring methods (code motion and merging
+algorithms). The implementation currently resides in the cfo-branch branch.</p>

"on the branch"?

+<p>The project includes two different code factoring algorithms which are the 
+following:</p>

How about "...includes the following two code factoring..."?

+<ul>
+<li>Local code factoring: This is code motion technique which tries to merge two
+identical instructions.</li>

"a code motion technique", and these lines are a bit long.

+<p>Both algorithms have an oportunity of working on two different levels 

opportunity

+(Tree, RTL). Both have their own advatages and disadvatages.

advantage, disadvantage

+<p>For more information about code factoring see the 
+<a href="http://www.gccsummit.org/2004/2004-GCC-Summit-Proceedings.pdf";>
+GCC Summit Proceedings</a>.</p>

Include the year (2004) as well?

Thanks,
Gerald

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]