This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR C/18479, visibility and structs and C

From: Andrew Pinski <pinskia at physics dot uc dot edu>
To: Andrew Pinski <pinskia at physics dot uc dot edu>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 25 Nov 2004 19:54:56 -0500
Subject: Re: [PATCH] Fix PR C/18479, visibility and structs and C
References: <59760A62-3F45-11D9-941D-000A95D692F4@physics.uc.edu>

On Nov 25, 2004, at 7:51 PM, Andrew Pinski wrote:

The problem is that the C TYPE_NAME of a type for a struct is a
IDENTIFIER_NODE but in C++ it is TYPE_DECL.  We just did not take
this into account in handle_visibility_attribute.  This patch fixes
the problem and we warn about the attribute being ignored also.

OK? Bootstrapped and tested on powerpc-darwin with no regressions.

Oh, I had forgot the testcase.

/* { dg-do compile } struct __attribute__ ((visibility("default"))) Foo { int foo; }; /* { dg-warning "attribute ignored on types" } */

-- Pinski

References:
- [PATCH] Fix PR C/18479, visibility and structs and C
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]