This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fixes some of PR 18463 and 17647, i386 address mode not being generated



On Nov 14, 2004, at 1:48 AM, Richard Henderson wrote:

Think about the path through this function via ashift and tell me what two unnecessary bits of work you see.

I know I should have not copied part of a function from combine.c. This new patch removes those two unnecessary bits and still helps out x86. There still other problems with respect with IV-OPTs making it more difficult to find the places where the addressing mode should be used.

OK? Stills bootstraps and no regressions on ppc-darwin and i686-linux-gnu.

Thanks,
Andrew Pinski

ChangeLog:
	* cse.c (canon_for_address): New function.
	(find_best_addr): Call canon_for_address before getting the
	address's cost when checking if we should take that address.


Attachment: temp.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]