This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR/18555
- From: Geoffrey Keating <geoffk at geoffk dot org>
- To: Devang Patel <dpatel at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 23 Nov 2004 14:00:30 -0800
- Subject: Re: [PATCH] PR/18555
- References: <11E5FEE7-3CD4-11D9-BEC3-000393A91CAA@apple.com>
Devang Patel <dpatel@apple.com> writes:
> Index: gcc/testsuite/gcc.dg/cpp/isysroot-1.c
> ===================================================================
> RCS file: gcc/testsuite/gcc.dg/cpp/isysroot-1.c
> diff -N gcc/testsuite/gcc.dg/cpp/isysroot-1.c
> *** /dev/null 1 Jan 1970 00:00:00 -0000
> --- gcc/testsuite/gcc.dg/cpp/isysroot-1.c 22 Nov 2004 22:03:32
> -0000
> ***************
> *** 0 ****
> --- 1,10 ----
> + /* { dg-options "-isysroot ${srcdir}/gcc.dg/cpp" } */
> + /* { dg-do compile } */
> +
> + #include <stdio.h>
> + int main()
> + {
> + /* Special stdio.h supplies function foo. */
> + foo();
> + return 0;
> + }
Did you check that this testcase does fail if the -isysroot isn't
there? You may need to write something like
void (*x)(void) = foo;
or foo() will be implicitly declared.
The isysroot-2 testcase might have the same problem.
With that change if necessary, this patch is OK.