This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to check_visibility_available


On Thu, Nov 18, 2004 at 05:15:00PM -0500, Daniel Jacobowitz wrote:
> On Thu, Nov 18, 2004 at 10:11:15PM +0000, Joseph S. Myers wrote:
> > This testsuite patch cleans up check_visibility_available in the
> > testsuite, by making it test the compiler rather than guessing based
> > on object format.
> > 
> > No testsuite regressions with this patch on i386-pc-solaris2.10.  OK
> > to commit?
> > 
> > 2004-11-18  Mark Mitchell  <mark@codesourcery.com>
> > 
> > 	* lib/target-supports.exp (check_visibility_available): Really
> > 	test the compiler.
> 
> I'm not sure I like this change.
> 
> Whether the just-build GCC supports .hidden can be affected by things
> that are hard to track down - for instance, configure testing the wrong
> assembler, though we're better about that now.  I think that we should
> maintain the list of targets which _should_ support a feature
> somewhere - either in the testsuite or in the documentation in a
> testsuite-parseable format.  That way, if the compiler should support
> hidden symbols but no longer does, we'll see testsuite failures.

This check is used by several tests via dg-require-visibility-available.
If you want to be sure that specific functionality is available for
specific targets, then add new tests (in the testsuite) to do that and
specify directly the list of targets to test.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]