This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH,committed] Fix PR17344 (missing tf_error check incoerce_template_parms)


Kriang Lerdsuwanakij wrote:


This bug is indeed template argument deduction problem. For the testcase
below, we first determine if 'int bar(S)' is a viable candidate by checking if 'A<int>' can be converted to 'S' via the template constructor. Here
we can deduce 'X' to 'A' (with current GCC template template parameter
matching) and proceed to check if 'A<void>' is valid.

Why do we check if "A<void>" is valid as part of SFINAE? I think that if we deduce X = A, whatever happens after that point is just an ordinary error, not SFINAE.


Do you still want me to revert the patch?

I don't want to create unncessary churn. I'd like to hear from Jason and Nathan on this issue.

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]