This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bug and pessimization for packed records in Ada


Eric Botcazou <ebotcazou@act-europe.fr> wrote:

> The patch I'm proposing is also twofold:
> - it swaps back the two blocks of code so that we cannot end up in a
> "semi-promoted" state anymore;

Why don't you add a gcc_assert somewhere to abort if you find this
semi-promoted state? Given that it's so invalid that SPARC generates wrong-code
with it, I think it is better to have the compiler ICE if ever build it
somehow.

> The patch also gets rid of the set_lang_adjust_rli hook that was
> added for Ada 3 years ago and silenced (but not removed) by Jason in

I guess you need to poison it?

Giovanni Bajo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]