This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR14172 partial fix


On Wed, 17 Nov 2004, Matthew Burgess wrote:

> Attached is a patch that partially fixes PR14172.  There are still two cases
> (in cp/class.c) where warnings are being output for system headers, but this
> fixes the other 6 trivial cases.

Please include testcases for each of these warnings that it is no longer 
output in system headers.  (For each case, a source file, with necessary 
markings such as { dg-options "-Weffc++" } which includes a header, which 
uses #pragma GCC system_header and contains the condition that shouldn't 
be diagnosed.  Make sure that the warning is given before the patch, and 
the presence of the test in the testsuite without any markers for expected 
warnings will ensure that it is checked that no warning is given after the 
patch.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]