This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Speedup/remove uses of is_gimple_reg (PHI_RESULT)


On Mon, Nov 15, 2004 at 08:32:42PM -0500, Andrew Pinski wrote:
> I noticed that a huge amount of time was being spent in is_gimple_reg.
> We were calling it on the result of a PHI_NODE to figure out if it was
> a virtual PHI node or not.  This patch "steals" the static bit to
> indicate if the PHI node is a virtual node.  This speeds up the compiler
> but I did not measure how much.  The is_gimple_reg on a profile using
> Shark goes down to below the 25th top function on the profile.
> 
> OK? Bootstrapped and tested on powerpc-darwin.

It sounds reasonable but...

Please, if you're submitting patches to improve performance, make some
comprehensive measurement to indicate you're doing the right thing.
This kind of micro-optimization can easily backfire.

-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]