This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ret_pointer_1.f90 XPASSes everywhere; propose to remove xfail line.


On Saturday 13 November 2004 14:27, Toon Moene wrote:
> Paul Brook wrote:
> > On Saturday 13 November 2004 11:12, Toon Moene wrote:
> >>I propose to remove the xfail line from
> >>testsuite/gfortran.dg/ret_pointer_1.f90, as it XPASSes now everywhere.
> >>
> >>2004-11-13  Toon Moene  <toon@moene.indiv.nluug.nl>
> >>
> >> * gfortran.dg/ret_pointer_1.f90: Don't xfail anymore.
> >
> > No. It still fails for me on i686-linux at -O2.
> > http://gcc.gnu.org/ml/gcc-testresults/2004-11/msg00573.html
> > Doesn't give details, bit it looks like the same is true there (the test
> > should be run 6 times).
>
> But wouldn't removing the xfail line at least concentrate our efforts on
> those few cases where it indeed, still, errors ?

I thought gcc policy was that the testsuite should have zero unexpected FAILs. 
Ie. spurious XPASSes are preferable to FAILs for known-broken tests. 

You were also proposing removing the comments mentioning the related PR, which 
has definitely not been fixed.

It's not a regression (that particular code never worked), so IMHO it can wait 
in line with any other wrong-code bugs we have :(

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]