This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Testsuite patch for Solaris 10


On Fri, Nov 12, 2004 at 07:14:05PM -0500, Daniel Jacobowitz wrote:
> On Fri, Nov 12, 2004 at 04:07:05PM -0800, Janis Johnson wrote:
> >   { dg-do run [dg-target-list target
> >        [dg-and [dg-or [istarget i?86-*-*] [istarget powerpc-*-linux]]
> >                [is-effective-target ilp32]]] }
> > 
> 
> Just my two cents... If I'm reading what you're trying to accomplish in
> that example correctly, I'd rather write it like this:
> 
> { dg-do run { target i?86-*-* powerpc-*-linux } }
> { dg-require ilp32 }
> 
> Yes, it doesn't have half the expressive flexibility.  When we run into
> this as a real problem, then we can define additional predicates which
> do whatever; we have that option.  I don't think we need to have
> boolean logic embedded in tests.
> 
> Also, without line breaks, that's _really_ hard to read!  Even with
> line breaks it's pretty hard, courtesy of TCL's nasted braces fetish.

Where it's really helpful to have logical AND is dg-error and friends so
the xfail or target list can combine targets and effective-target
information; there might be a test that runs everywhere but is a known
failure for powerpc64-*-* when generating 64-bit code, but not for
32-bit code.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]