This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Testsuite patch for Solaris 10

Joseph S. Myers wrote:

AMD64 Solaris 10 defaults to 32-bit compilation so has target triple
i386-pc-solaris2.10, but builds 64-bit multilibs.  Various testcases
that are for i?86-*-* only, not x86_64-*-*, need to disable the use of
-m64.  This patch (around a third of the changes present on
csl-sol210-branch) adds dg-forbid-option to achieve this.  As various
significant test harness changes have been being discussed lately for
mainline, I hope this too can be considered for mainline now.

(This patch isn't quite identical to that on csl-sol210-branch; there
are whitespace fixes, ChangeLog typo fixes and some tests have been
adjusted only to disallow -m64 on i?86-*-* where they are tested on
all targets but have special 32-bit-only options on x86, rather than
disallowing it everywhere as some but not most such tests did.)

As a sanity check for TCL syntax, there are no testsuite regressions
with this patch on i686-pc-linux-gnu.  OK to commit?

Certrainly, from an RM point of view, testsuite changes are fine at this point. The fewer spurious FAILs the better, and this problem could affect platforms other than Solaris 2.10 as well. So, this patch is OK.


- Mark Mitchell
CodeSourcery, LLC
(916) 791-8304

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]