This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Gomp] Adding libgomp


On Wednesday 10 November 2004 19.52, Diego Novillo wrote:
> I've committed the attached patch to the branch.  There should be no
> functional changes wrt Biagio's original patch:
>
[...]
>      3. I added GPL+exception notices to all the header files (note: if
>         this is going to be a problem for the libgomp folks, then we'll
>         have to pull the files out and figure it out before going
>         further).
>

Diego, it's good you brought up this issue very early.

We don't have any problem with that. But a potential problem is the fact that 
the code is public domain: it is an almost literal transposition of what's 
written in Appendix  B of the OpenMP standard. True, we could have 
implemented it without looking at the standard, but you will come up with 
identical code. Consider for instance the function 

int omp_get_num_procs(void)

This must return the number of the processor in the system. In the stub case, 
this is 1, and (barring indentation and personal style) every developer on 
Earth would write

int omp_get_num_procs(void)
{
	return 1;
}

which is exactly what is written in the standard. Almost all the stubs work 
this way, so there is no much space here for independent implementation based 
on the standard. This is why I would classify this code as public domain: it 
is in the appendix of a book and there is no way of having it implemented 
directly. This is why we tried to be careful with the license. The question 
is: are we allowed to put our favorite license on those files? If not, this 
is a problem in principle for OpenMP to be in GCC.

Biagio


-- 
=========================================================

Biagio Lucini				      
Institut Fuer Theoretische Physik
ETH Hoenggerberg      
CH-8093 Zuerich - Switzerland           
Tel. +41 (0)1 6332562  
 
=========================================================


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]